Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure grid layout remains consistent for long product names #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gajda-w
Copy link

@gajda-w gajda-w commented Jan 19, 2025

I want to merge this change because it fixes an issue with the product grid when the product name consists of more characters. When the product name is long, the product grid does not display correctly. Adding the hidden parameter to the product thumbnail ensures that products with long names do not 'stretch' in the grid. This change improves the user interface by ensuring that long product names do not cause layout issues, resulting in a more consistent and user-friendly product grid display.

Before:
image

After:
image

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2025 3:52pm

Copy link

vercel bot commented Jan 19, 2025

@gajda-w is attempting to deploy a commit to the Mirumee Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant