Uml 3764 remove one login feature flag #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # terraform/environment/region/api_ecs.tf # terraform/environment/terraform.tfvars.json
github-actions
bot
added
php
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
============================================
- Coverage 91.95% 91.94% -0.01%
+ Complexity 1781 1779 -2
============================================
Files 391 391
Lines 8276 8268 -8
============================================
- Hits 7610 7602 -8
Misses 649 649
Partials 17 17
|
cooperaj
previously approved these changes
Jan 14, 2025
| @@ -16,15 +16,8 @@ public function __invoke(ContainerInterface $container): AuthenticationMiddlewar | |||
| { | |||
| $pipe = $container->get(MiddlewarePipeInterface::class); | |||
| $credentialAuthenticationMiddleware = $container->get(CredentialAuthenticationMiddleware::class); | |||
There was a problem hiding this comment.
Might need to have a think about the credential middleware and how that works. Probably in a follow up ticket. We don't need a lot of what that provides now.
# Conflicts: # service-front/app/features/context/Integration/AccountContext.php
cooperaj
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
removing the gov one login feature flag and usages
Fixes UML-3764
Checklist (tick/delete or
strikethroughas appropriate)