Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uml 3394 combined lpa manager #2782

Merged
merged 100 commits into from
Jan 20, 2025

Remove added feature flag from behat test configuration

461ed67
Select commit
Loading
Failed to load commit list.
Merged

Uml 3394 combined lpa manager #2782

Remove added feature flag from behat test configuration
461ed67
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

91.77% (target 80.00%)

View this Pull Request on Codecov

91.77% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 96.57388% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (38c7bd6) to head (461ed67).

Files with missing lines Patch % Lines
.../app/src/App/src/Service/JWT/JWSBuilderFactory.php 0.00% 5 Missing ⚠️
...p/src/App/src/DataAccess/ApiGateway/SiriusLpas.php 0.00% 4 Missing ⚠️
...app/src/App/src/Service/Lpa/CombinedLpaManager.php 96.42% 3 Missing ⚠️
.../src/App/src/DataAccess/ApiGateway/GenerateJWT.php 0.00% 1 Missing ⚠️
...vice-api/app/src/App/src/Service/Lpa/SiriusLpa.php 0.00% 1 Missing ⚠️
...nt/app/src/Common/src/Service/Lpa/ParseLpaData.php 92.30% 1 Missing ⚠️
...ront/app/src/Common/src/View/Twig/LpaExtension.php 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2782      +/-   ##
============================================
- Coverage     91.94%   91.77%   -0.17%     
+ Complexity     1779     1747      -32     
============================================
  Files           391      360      -31     
  Lines          8269     8172      -97     
============================================
- Hits           7603     7500     -103     
- Misses          649      655       +6     
  Partials         17       17
Files with missing lines Coverage Δ
...rc/App/src/DataAccess/ApiGateway/DataStoreLpas.php 98.73% <100.00%> (-1.27%) ⬇️
...src/DataAccess/ApiGateway/DataStoreLpasFactory.php 100.00% <100.00%> (ø)
...src/DataAccess/ApiGateway/RequestSignerFactory.php 100.00% <100.00%> (ø)
...src/App/src/DataAccess/Repository/Response/Lpa.php 100.00% <100.00%> (ø)
...p/src/App/src/Entity/Casters/CastToCaseSubtype.php 100.00% <100.00%> (ø)
...c/Entity/Casters/CastToLifeSustainingTreatment.php 100.00% <100.00%> (ø)
...p/src/Entity/Casters/CastToWhenTheLpaCanBeUsed.php 100.00% <100.00%> (ø)
...App/src/Entity/Casters/ExtractAddressFieldFrom.php 100.00% <100.00%> (ø)
service-api/app/src/App/src/Entity/Lpa.php 100.00% <100.00%> (ø)
...e-api/app/src/App/src/Entity/LpaStore/LpaStore.php 92.50% <100.00%> (+1.59%) ⬆️
... and 38 more

... and 1 file with indirect coverage changes

View more details on Codecov