[WIP] Check support for govuk-frontend v5 #415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with the changes to govuk-frontend in version 5 of the Design System, alongside related changes in MOJ Pattern Library.
NB: to test locally, you must copy the contents of the MOJPL
package
folder from its WIP branch into a folder in the root of this repo called./moj-frontend
.Changes we have to make:
data-module="govuk-details"
(it no longer does anything)[disabled]
attribute rather thangovuk-button--disabled
class (which has been removed)I haven't added
type="module"
to the<script>
tag because we don't need to, but we might like to do so for closer alignment with GDS guidance.#major