Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Check support for govuk-frontend v5 #415

Closed
wants to merge 0 commits into from

Conversation

gregtyler
Copy link
Contributor

Testing with the changes to govuk-frontend in version 5 of the Design System, alongside related changes in MOJ Pattern Library.

NB: to test locally, you must copy the contents of the MOJPL package folder from its WIP branch into a folder in the root of this repo called ./moj-frontend.

Changes we have to make:

  • Update path of dist files in govuk-frontend
  • Remove data-module="govuk-details" (it no longer does anything)
  • Use [disabled] attribute rather than govuk-button--disabled class (which has been removed)
  • Update body class initialisation

I haven't added type="module" to the <script> tag because we don't need to, but we might like to do so for closer alignment with GDS guidance.

#major

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@gregtyler gregtyler closed this Jan 24, 2024
@gregtyler gregtyler force-pushed the wip-govuk-frontend-v5-support branch from 0a60dcd to b618c7d Compare January 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants