Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-370 Non primary accounts should get redirect message instead of add client #1790

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

iqpalm
Copy link
Contributor

@iqpalm iqpalm commented Jan 8, 2025

Purpose

Non primary accounts that have no active clients associated with them are taken to the add client screen instead of the ‘use your other account’ screen.

Fixes DDLS-370

Approach

Added in test to cover the scenario where secondary account with discharged client tries to login and is logged out and flash message appears with primary email address to login with.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

Iqpal Mannan and others added 2 commits January 8, 2025 13:24
@iqpalm iqpalm marked this pull request as ready for review January 8, 2025 14:29
@iqpalm iqpalm requested a review from a team as a code owner January 8, 2025 14:29
@iqpalm iqpalm merged commit 2923219 into main Jan 10, 2025
36 of 37 checks passed
@iqpalm iqpalm deleted the DDLS-370 branch January 10, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants