Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-180 - Populate Court Order table with active court order data from CSVs #1614

Closed
wants to merge 20 commits into from

Conversation

Raffers
Copy link
Contributor

@Raffers Raffers commented Jun 21, 2024

Purpose

Populate table with data from CSVs when they are ingested.

This would be just populating data into this table only, without creating any links between other tables/rows.

This would also ingest the new data into the pre-registration table and related fixtures.

Acceptance Criteria:

  • When the Lay and Org CSV is initially processed, reject the CSV if there is no CourtOrderUid column present.
  • When processing a row from the Lay and Org CSV, reject a row if there isn’t a valid value in the CourtOrderUid column.
  • When the Lay and Org CSV is ingested, if a new court order uid is present, create a new court order entry.
  • When the Lay and Org CSV is ingested, compare our existing court order uids against the court order uids present in said CSVs:
    • If they are present, update the type if it has changed.
    • If they are not present, we should mark them as inactive.

Fixes DDLS-180

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

ndasmoj and others added 16 commits April 18, 2024 14:42
# Conflicts:
#	api/app/src/Command/ProcessOrgCSVCommand.php
#	api/app/src/FixtureFactory/PreRegistrationFactory.php
#	api/app/src/Migrations/Version277.php
#	api/app/src/v2/Registration/Uploader/OrgDeputyshipUploader.php
#	api/app/tests/Behat/bootstrap/v2/Common/BaseFeatureContext.php
#	api/app/tests/Behat/bootstrap/v2/Helpers/FixtureHelper.php
#	api/app/tests/Behat/bootstrap/v2/Registration/IngestTrait.php
#	api/app/tests/Behat/features-v2/registration/ingest.org.sirius.feature
#	api/app/tests/Unit/Command/ProcessOrgCSVCommandTest.php
#	api/app/tests/Unit/Controller/SelfRegisterControllerTest.php
#	api/app/tests/Unit/v2/Registration/TestHelpers/OrgDeputyshipDTOTestHelper.php
#	api/app/tests/Unit/v2/Registration/Uploader/OrgDeputyshipUploaderTest.php
@Raffers Raffers requested a review from a team as a code owner June 21, 2024 16:09
…ic in uploaders

DDLS-180 - Behat & Unit test fixes. Update to CourtOrder handling logic in uploaders

DDLS-180 - Behat & Unit test fixes. Update to CourtOrder handling logic in uploaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants