Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabbed-view-documents): tabbed view documentation #989

Merged
merged 27 commits into from
Dec 20, 2024

Conversation

jbarnardmoj
Copy link
Contributor

Ability to tab content in documentation.

@jbarnardmoj jbarnardmoj self-assigned this Dec 11, 2024
@jbarnardmoj jbarnardmoj marked this pull request as ready for review December 11, 2024 10:36
@jbarnardmoj jbarnardmoj requested a review from a team as a code owner December 11, 2024 10:36
@jbarnardmoj jbarnardmoj added the staging:request Add this label to request a staging environment for a pull request label Dec 12, 2024
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request staging:active Automatic label added when the PR is on the staging environment labels Dec 12, 2024
@jbarnardmoj jbarnardmoj added the preview:request Deploy PR to a preview url label Dec 19, 2024
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

@github-actions github-actions bot added preview:active and removed preview:request Deploy PR to a preview url labels Dec 19, 2024
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

.eleventy.js Outdated Show resolved Hide resolved
@@ -0,0 +1,284 @@
.app-navigation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not wild about this classname, but I can live with it.

However I think some of these customisations may need to also include the .js-enabled class, or some extra work needs to happen for the no-js version as it currently looks like this:

image

The gov.uk tabs look like this (without JS):
image

I think I'd err towards having it look as per gov.uk tabs without js and then enhance to what we have now. Might be as simple as .js-enabled .app-navigation

Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

@jbarnardmoj jbarnardmoj merged commit 5cc6185 into main Dec 20, 2024
19 checks passed
@jbarnardmoj jbarnardmoj deleted the tabbed-view-documentation branch December 20, 2024 12:08
gregtyler pushed a commit that referenced this pull request Dec 20, 2024
# [3.3.0](v3.2.2...v3.3.0) (2024-12-20)

### Features

* **tabbed-view-documents:** tabbed view documentation ([#989](#989)) ([5cc6185](5cc6185))
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants