-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabbed-view-documents): tabbed view documentation #989
Conversation
…sub navigation at the moment
… mixins so that we can use it for our usage of tabs (giving the style of sub nav) in a tabbed documentation page
…ated from component styles
🚀 Deploying to staging environment Username: |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
@@ -0,0 +1,284 @@ | |||
.app-navigation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not wild about this classname, but I can live with it.
However I think some of these customisations may need to also include the .js-enabled
class, or some extra work needs to happen for the no-js version as it currently looks like this:
The gov.uk tabs look like this (without JS):
I think I'd err towards having it look as per gov.uk tabs without js and then enhance to what we have now. Might be as simple as .js-enabled .app-navigation
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
# [3.3.0](v3.2.2...v3.3.0) (2024-12-20) ### Features * **tabbed-view-documents:** tabbed view documentation ([#989](#989)) ([5cc6185](5cc6185))
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-tabbed-view-documentation.apps.live.cloud-platform.service.justice.gov.uk Username: |
Ability to tab content in documentation.