Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributions): contribution process and criteria #526

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

robertjmccarthy
Copy link
Contributor

Description of change

Inclusion of a contribution process and guidance on how to contribute into the MOJ Design System.

Inclusion of a contribution process and criteria within the community section of the site
@robertjmccarthy robertjmccarthy added the staging:request Add this label to request a staging environment for a pull request label Oct 25, 2023
@robertjmccarthy robertjmccarthy requested a review from a team as a code owner October 25, 2023 13:36
Comment on lines 26 to 47
<!-- ## What happens next

### Review and decision

The MOJ Design System Group will review your contribution and get back to you with a decision on whether your contribution will be accepted into the design system.

The Group may reach out to you to discuss your contribution before making a decision.

### Developing your contribution

If your contribution is accepted, the Group will work with you to support the development of your contribution into a common style, component or pattern that other teams can reuse.

<article class="moj-ticket-panel" style="margin-top: 60px">
<section class="moj-ticket-panel__content moj-ticket-panel__content--blue">
<h3 class="govuk-heading-m govuk-!-margin-bottom-3">Useful links</h3>
<ul class="govuk-list">
<li><a class="govuk-link" href="/community/criteria">Contribution criteria</a></li>
<li><a class="govuk-link" href="https://docs.google.com/spreadsheets/d/1TlF5XxAoE_SPB9JBg1IktY0W30d4kMElwSLGclzL0wQ/edit?usp=sharing">Contribution backlog</a></li>
<li><a class="govuk-link" href="https://forms.gle/Hp56F9mYxz8Mh4BZ8">Propose a contribution</a></li>
</ul>
</section>
</article> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good spot. It can be removed.

docs/community/criteria.md Outdated Show resolved Hide resolved

### Step 3: Propose your contribution

Propose a contribution using the [contribution form](https://forms.gle/Hp56F9mYxz8Mh4BZ8). When submitted, your contribution can be viewed on the [contribution backlog](https://docs.google.com/spreadsheets/d/1TlF5XxAoE_SPB9JBg1IktY0W30d4kMElwSLGclzL0wQ/edit?usp=sharing).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also highlight the ability to suggest a contribution over GitHub, since that's an easier way of sharing code changes for anyone who's already familiar with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, as we want contributions to work for everyone so tooling needs to be right for different people.

But right now we need to balance this with handling contributions in an organised way that we can manage and review as a the MOJ Design System Group. Not suggesting this is perfect right now, but it's low barrier for people to contribute and easy for us to review contributions as a group.

There haven't been contributions for a while, and there could be a lot of contributions soon to come in. Having them coming in in different ways will mean we'll struggle to be organised at this very early stage.

@robertjmccarthy robertjmccarthy merged commit 95f544c into main Oct 30, 2023
6 checks passed
@robertjmccarthy robertjmccarthy deleted the contributions branch October 30, 2023 11:06
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released staging:request Add this label to request a staging environment for a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants