docs(examples): update example css to reflect real-life usage #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in our examples was using application.css, which is a sass compiled file including all of govuk frontend, moj-frontend and all the custom styles for the docs site. This could cause potential issues where our own css could affect components. This commit refactors things such that the example layout includes compiled govuk-frontend and (separately) compiled moj-frontend and none of the docs site css. This ensure we are presenting (and testing) components in a more isolated way with no danger of style leakage.
|
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-refactor-example-layout-css.apps.live.cloud-platform.service.justice.gov.uk Username: |
github-actions
bot
added
preview:active
and removed
preview:request
|
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-refactor-example-layout-css.apps.live.cloud-platform.service.justice.gov.uk Username: |
jbarnardmoj
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in our examples was using
application.csswhich is a sass compiled file including all of govuk frontend, moj-frontend and all the custom styles for the docs site. This could cause potential issues where our own css could affect components.This PR refactors things such that the example layout includes compiled govuk-frontend and (separately) compiled moj-frontend and none of the docs site css.
This ensure we are presenting (and testing) components in a more isolated way with no danger of style leakage.