Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interruption card): fix body text color when govuk-global-styles is true #1059

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

chrispymm
Copy link
Contributor

If the component is used when govuk global styles is set to true, the specificity isn't high enough to override the text color to white.

This PR adds extra css to ensure elements within the interruption card body are given the correct text size and color.

…is true

If the component is used when govuk global styles is set to true, the i
specificity isn't high enough to override the text color to white.
This commit adds extra css to ensure elements within the interruption
card body are given the correct text size and color.
@chrispymm chrispymm requested a review from a team as a code owner January 9, 2025 12:18
@chrispymm chrispymm merged commit a25af13 into v3.3.1 Jan 9, 2025
3 checks passed
@chrispymm chrispymm deleted the interruption-card-text-color-fix branch January 9, 2025 12:18
chrispymm added a commit that referenced this pull request Jan 9, 2025
)

* fix(interruption card): fix body text color when govuk-global-styles is true (#1059)

If the component is used when govuk global styles is set to true, the i
specificity isn't high enough to override the text color to white.
This commit adds extra css to ensure elements within the interruption
card body are given the correct text size and color.

* fix(inital): remove duplicate initialisation block in all.js (#1060)

The code block to initialize sortable table copmonents was duplicated

* fix(initall): ensure datepickers respect scope when initialised (#1061)

Datepickers were always initialised within the document scope, and would ignore any scope passed to
the intiAll function.
gregtyler pushed a commit that referenced this pull request Jan 9, 2025
## [3.3.1](v3.3.0...v3.3.1) (2025-01-09)

### Bug Fixes

* text color in interruption card and initAll function updates ([#1062](#1062)) ([c8a3800](c8a3800)), closes [#1059](#1059) [#1060](#1060) [#1061](#1061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant