Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update apply service pattern page #1033

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

helennickols
Copy link
Contributor

No description provided.

@helennickols helennickols requested a review from a team as a code owner December 18, 2024 16:26
@helennickols helennickols added the staging:request Add this label to request a staging environment for a pull request label Dec 18, 2024
docs/apply.md Outdated
@@ -0,0 +1,145 @@
---
layout: layouts/apply-service-pattern.njk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How comes you've created a specific layout for this page? Could it work with an existing layout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentional. I didn't realise that I'd done so. Shall I use this one instead?
layout: layouts/service-patterns.njk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, best to use that one. That layout strips out anything unnecessary for an orphaned page.

docs/apply.md Outdated

## Stages and steps

## User scenarios
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an H2 and above it is an H2. Should this be an H3 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be, yes.

@robertjmccarthy robertjmccarthy added preview:request Deploy PR to a preview url and removed staging:request Add this label to request a staging environment for a pull request labels Dec 23, 2024
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

@github-actions github-actions bot added preview:active and removed preview:request Deploy PR to a preview url labels Dec 23, 2024
Copy link
Contributor

@murrlipp murrlipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Some are about content style so maybe not relevant as I believe this has been reviewed by the CD community.

docs/service-patterns/apply.md Show resolved Hide resolved
docs/service-patterns/apply.md Outdated Show resolved Hide resolved
docs/service-patterns/apply.md Outdated Show resolved Hide resolved
docs/service-patterns/apply.md Outdated Show resolved Hide resolved
docs/service-patterns/apply.md Show resolved Hide resolved
docs/service-patterns/apply.md Show resolved Hide resolved
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Copy link
Contributor

@murrlipp murrlipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the template, other than that the changes look good.

docs/_includes/layouts/service-patterns.njk Show resolved Hide resolved
@robertjmccarthy robertjmccarthy merged commit dcd3f48 into main Dec 23, 2024
19 checks passed
@robertjmccarthy robertjmccarthy deleted the apply-service-pattern branch December 23, 2024 14:18
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 9, 2025

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants