-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update apply service pattern page #1033
Conversation
docs/apply.md
Outdated
@@ -0,0 +1,145 @@ | |||
--- | |||
layout: layouts/apply-service-pattern.njk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How comes you've created a specific layout for this page? Could it work with an existing layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not intentional. I didn't realise that I'd done so. Shall I use this one instead?
layout: layouts/service-patterns.njk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, best to use that one. That layout strips out anything unnecessary for an orphaned page.
docs/apply.md
Outdated
|
||
## Stages and steps | ||
|
||
## User scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an H2 and above it is an H2. Should this be an H3 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be, yes.
e665cc4
to
a568a70
Compare
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk Username: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Some are about content style so maybe not relevant as I believe this has been reviewed by the CD community.
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk Username: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the template, other than that the changes look good.
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL: https://moj-frontend-apply-service-pattern.apps.live.cloud-platform.service.justice.gov.uk Username: |
No description provided.