-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: stop directly requiring govuk-frontend SCSS
Directly requiring individual govuk-frontend SCSS files is risky, as govuk-frontend could move their internal files and break our compatibility. This has happened in v5 of govuk-frontend, and we cannot support both ≤v4 and v5 at the same time with the current method. Instead, we will require users to separately import govuk-frontend before moj-frontend. In reality users should already be doing this, as using moj-frontend code without govuk-frontend will cause an inconsistent UI. Anyone who _isn't_ doing so already will just need a one line import: ```scss @import "node_modules/govuk-frontend/dist/govuk/all"; ``` To still be able to build our distributable version, which also requires govuk-frontend code to be built, create a wrapper `dist.scss` with the specific imports required. BREAKING CHANGE: If you are building moj-frontend from SCSS, you must include govuk-frontend beforehand
- Loading branch information
Showing
7 changed files
with
12 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
$govuk-is-ie8: true; | ||
|
||
@import "all"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
$_govuk-imported-modules: ("govuk/objects/width-container") !default; | ||
|
||
@import "node_modules/govuk-frontend/dist/govuk/base"; | ||
@import "node_modules/govuk-frontend/dist/govuk/objects/width-container"; | ||
@import "package/moj/all" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters