Filter OpenSearch Packages causing aws-nuke failures #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
environments-repository
ASTRobinson
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
The scheduled AWS Nuke workflow has been failing with a common issue in the logs related to OpenSearch packages.
e.g.
Changes Made
I've added more filters to the Nuke config to ignore these packages. As far as I can tell these aren't specific resources that are created by users as they occur in all of the accounts being nuked.
Testing
I've carried out a dry-run of the nuke and can see the packages are being filtered here - Will have to wait over the weekend to see if it works for sure