Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed misplaced zip files from xhibit portal #8742

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Nov 21, 2024

Tracked upstream by #8393 in the modernisation platform repository.

Removes unneeded zip files prior to our .gitignore ignoring all zip files in the repository by default. See this Slack conversation for confirmation.

@dms1981 dms1981 requested review from a team as code owners November 21, 2024 17:26
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Nov 21, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@zoltan-paldi
Copy link
Contributor

@dms1981 Thank you for deleting those archive files. Could you please add the path to .gitignore file as well? Thank you.

Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dms1981 dms1981 merged commit 4708fee into main Nov 22, 2024
8 of 11 checks passed
@dms1981 dms1981 deleted the feature/8393-remove-xp-zip-archives branch November 22, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants