Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Code Formatter workflow #3969

Merged
merged 3 commits into from
Nov 14, 2023
Merged

GitHub Actions Code Formatter workflow #3969

merged 3 commits into from
Nov 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This pull request includes updates from the GitHub Actions Code Formatter workflow. Please review the changes and merge if everything looks good.

@github-actions github-actions bot added the code quality For PRs that improve, reformat, or refactor code label Nov 13, 2023
@github-actions github-actions bot requested review from a team as code owners November 13, 2023 04:50
@github-actions github-actions bot requested review from a team November 13, 2023 04:50
@github-actions github-actions bot requested review from a team as code owners November 13, 2023 04:50
ASTRobinson
ASTRobinson previously approved these changes Nov 14, 2023
Copy link
Contributor

@ASTRobinson ASTRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - linting changes only.

@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Nov 14, 2023
@ASTRobinson ASTRobinson had a problem deploying to nomis-data-hub-development November 14, 2023 09:58 — with GitHub Actions Failure
@ASTRobinson ASTRobinson had a problem deploying to ccms-ebs-upgrade-development November 14, 2023 09:58 — with GitHub Actions Failure
Copy link
Contributor Author

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/oasys

*****************************

Running TFSEC in terraform/environments/oasys
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.473878ms
  parsing              223.722226ms
  adaptation           150.992µs
  checks               3.392202ms
  total                228.739298ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     268
  files read           70

  results
  ──────────────────────────────────────────
  passed               7
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/oasys

*****************************

Running Checkov in terraform/environments/oasys
terraform scan results:

Passed checks: 90, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/oasys

*****************************

Running tflint in terraform/environments/oasys
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ASTRobinson ASTRobinson had a problem deploying to nomis-combined-reporting-test November 14, 2023 09:58 — with GitHub Actions Failure
fixing conflicts
Copy link
Contributor

@ASTRobinson ASTRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - linting changes only

@ASTRobinson ASTRobinson had a problem deploying to ccms-ebs-upgrade-development November 14, 2023 10:00 — with GitHub Actions Failure
@ASTRobinson ASTRobinson had a problem deploying to nomis-data-hub-development November 14, 2023 10:01 — with GitHub Actions Failure
Copy link
Contributor Author

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/oasys

*****************************

Running TFSEC in terraform/environments/oasys
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.514128ms
  parsing              238.937051ms
  adaptation           156.011µs
  checks               3.590014ms
  total                244.197204ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     268
  files read           70

  results
  ──────────────────────────────────────────
  passed               7
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/oasys

*****************************

Running Checkov in terraform/environments/oasys
terraform scan results:

Passed checks: 90, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/oasys

*****************************

Running tflint in terraform/environments/oasys
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ASTRobinson ASTRobinson merged commit ca441ad into main Nov 14, 2023
58 of 68 checks passed
@ASTRobinson ASTRobinson deleted the date_2023_11_13 branch November 14, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality For PRs that improve, reformat, or refactor code environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants