Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Replace read-dns-records with read-log-records role #3618

Merged
merged 1 commit into from
Oct 10, 2023
Merged

🔧 Replace read-dns-records with read-log-records role #3618

merged 1 commit into from
Oct 10, 2023

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Oct 10, 2023

This PR relates to ministryofjustice/modernisation-platform#5001

The read-dns-records role is in scope for expansion to allow Modernisation Platform customers wider access to records stored in our core-network-services account. As this expands the role beyond reading DNS records, the role is being replaced by read-log-records.

This PR updates the platform_providers.tf files so that when Modernisation Platform customers execute local terraform plans they assume the new read-log-records role which will allow us to remove the old read-dns-records role.

@dms1981 dms1981 requested review from a team as code owners October 10, 2023 09:51
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Oct 10, 2023
@dms1981 dms1981 changed the title Replace read-dns-records with read-log-records role 🔧 Replace read-dns-records with read-log-records role Oct 10, 2023
@dms1981 dms1981 had a problem deploying to pra-register-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to wardship-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to data-platform-test October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to hmpps-domain-services-test October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 mentioned this pull request Oct 10, 2023
Merged
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@dms1981 dms1981 had a problem deploying to maatdb-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to data-and-insights-wepi-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to hmpps-domain-services-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to sprinkler-development October 10, 2023 09:54 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to sprinkler-development October 10, 2023 09:56 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to data-platform-test October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to ccms-ebs-development October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to portal-development October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to digital-prison-reporting-development October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to delius-jitbit-test October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to digital-prison-reporting-test October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 temporarily deployed to tariff-development October 10, 2023 09:57 — with GitHub Actions Inactive
@dms1981 dms1981 had a problem deploying to laa-oem-development October 10, 2023 09:57 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to delius-jitbit-test October 10, 2023 10:00 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to cooker-development October 10, 2023 10:00 — with GitHub Actions Failure
@dms1981 dms1981 temporarily deployed to tariff-development October 10, 2023 10:00 — with GitHub Actions Inactive
@dms1981 dms1981 had a problem deploying to portal-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to delius-core-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to example-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to pra-register-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to planetfm-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to laa-oem-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to mojfin-development October 10, 2023 10:01 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to ccms-ebs-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to data-platform-apps-and-tools-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to hmpps-oem-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to maatdb-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to data-and-insights-wepi-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to digital-prison-reporting-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to hmpps-domain-services-test October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to mojfin-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to wardship-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 had a problem deploying to example-development October 10, 2023 10:02 — with GitHub Actions Failure
@dms1981 dms1981 merged commit 7ad8fc5 into main Oct 10, 2023
609 of 711 checks passed
@dms1981 dms1981 deleted the feature/5001-expand-dns-role branch October 10, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASTRobinson ASTRobinson ASTRobinson approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dms1981 @ASTRobinson