Merge pull request #5563 from ministryofjustice/CC-2488/correct-dns-e…

…ntries

CC-2488: ccms-ebs-app-X-upgrade -> ccms-ebs-appX-upgrade

terraform/environments/ccms-ebs-upgrade/r53.tf

@@ -1,4 +1,4 @@
-## EBSDB
+# EBS DB
 resource "aws_route53_record" "ebsdb" {
   provider = aws.core-vpc
   zone_id  = data.aws_route53_zone.external.zone_id
@@ -8,8 +8,7 @@ resource "aws_route53_record" "ebsdb" {
   records  = [aws_instance.ec2_oracle_ebs.private_ip]
 }
 
-
-## EBS Conc
+# EBS Conc
 resource "aws_route53_record" "ebsconc" {
   provider = aws.core-vpc
   zone_id  = data.aws_route53_zone.external.zone_id
@@ -19,18 +18,18 @@ resource "aws_route53_record" "ebsconc" {
   records  = [aws_instance.ec2_oracle_conc.private_ip]
 }
 
-## EBSAPPS
+# EBS Apps
 resource "aws_route53_record" "ebsapps" {
   provider = aws.core-vpc
   count    = local.application_data.accounts[local.environment].ebsapps_no_instances
   zone_id  = data.aws_route53_zone.external.zone_id
-  name     = "ccms-ebs-app-${count.index + 1}-upgrade.${var.networking[0].business-unit}-${local.environment}.modernisation-platform.service.justice.gov.uk"
+  name     = "ccms-ebs-app${count.index + 1}-upgrade.${var.networking[0].business-unit}-${local.environment}.modernisation-platform.service.justice.gov.uk"
   type     = "A"
   ttl      = 300
   records  = [aws_instance.ec2_ebsapps[count.index].private_ip]
 }
 
-## EBS ALB
+# EBS ALB
 resource "aws_route53_record" "external" {
   provider = aws.core-vpc
 
@@ -45,9 +44,7 @@ resource "aws_route53_record" "external" {
   }
 }
 
-
 # AccessGate Instances
-
 resource "aws_route53_record" "accessgate_ec2" {
   provider = aws.core-vpc
   count    = local.application_data.accounts[local.environment].accessgate_no_instances
@@ -60,7 +57,6 @@ resource "aws_route53_record" "accessgate_ec2" {
 }
 
 # WebGate Instances
-
 resource "aws_route53_record" "webgate_ec2" {
   provider = aws.core-vpc
   count    = local.application_data.accounts[local.environment].webgate_no_instances