Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBA-73 - update current offences task with community supervision and CPP details pages #47

Merged

Conversation

patrickjfl
Copy link
Contributor

Context

Jira ticket: https://dsdmoj.atlassian.net/browse/CBA-73

Changes in this PR

Updates the current offences task to be 'Community supervision and current offences'. The answer given on the first page in the task (community supervision) determines whether the user is required to complete the other pages in the task. If not, they are redirected back to the task list.

Screenshots of UI changes

Screenshot 2025-01-07 at 16 25 49

Screenshot 2025-01-07 at 16 26 01

Release checklist

As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:

Pre merge checklist

  • Are any changes required to the e2e tests?
  • If you've added a new route, have you added a new
    auditEvent? (see server/routes/apply.ts for examples)
  • Are there environment variables or other infrastructure configuration which needs to be included in this release?
  • Are there any data migrations required. Automatic or manual?
  • Does this rely on changes being deployed to the CAS API?

Post merge

Once we've merged it will be auto-deployed to the dev environment.

Patrick Fleming added 4 commits January 7, 2025 16:14
If the applicant is under community supervision, then there is a current offence which needs to be recorded. So we will use this page to determine whether the user needs to continue with the later pages of the task (adding CPP details current offence data).
This has been brought back in from CAS2 HDC, albeit in a different task.
@patrickjfl patrickjfl requested a review from libuk January 7, 2025 16:41
@patrickjfl patrickjfl changed the title CBA-73 - add a new question flow for community supervision CBA-73 - update current offences task with community supervision and CPP details pages Jan 7, 2025
libuk
libuk previously approved these changes Jan 7, 2025
Copy link
Contributor

@libuk libuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@libuk libuk dismissed their stale review January 8, 2025 12:38

Some more work needed around applicationData and orphaned data.

Daniel Liburd added 2 commits January 8, 2025 17:01
If a user answers yes to the community supervision question and fills in
subsequent screens, the data will persist even after coming back to change the
answer to 'no' and will show on the check your answers screen and be submitted
with the application.

This change ensures we remove that data when the answer is 'no.
@libuk libuk force-pushed the CBA-73-add-a-new-question-flow-for-community-supervision branch from fcd12a3 to 774ab28 Compare January 8, 2025 17:07
@libuk libuk merged commit 51cddfb into main Jan 8, 2025
9 checks passed
@libuk libuk deleted the CBA-73-add-a-new-question-flow-for-community-supervision branch January 8, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants