CBA-71 - remove OASys import pages #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2025 10:14
We have taken the decision to remove the import of OASys data in favour of manual input. This means we need to remove the import page as well as other references to OASys from the task.
We have taken the decision to remove the import of OASys data in favour of manual input. This means we need to remove the import page as well as other references to OASys from the task.
patrickjfl
force-pushed
the
CBA-71-remove-oa-sys-import-pages
branch
from
71c498e to
fa9f565
Compare
libuk
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Really thorough and well laid out, nice work!
I think we have a couple of types that can be removed from @types/ui/index.d.ts
export type OasysImportArrays = ArrayOfOASysRiskOfSeriousHarmSummaryQuestions
export type RiskLevel = 'Low' | 'Medium' | 'High' | 'Very High'
|
ah yeah, good spot!
|
added 3 commits
January 7, 2025 10:38
This was causing check your answers to error when a date is not entered.
Now that we’ve removed the OASys import from the risk tasks, we need to update the E2E tests.
patrickjfl
force-pushed
the
CBA-71-remove-oa-sys-import-pages
branch
from
fa9f565 to
fb84102
Compare
libuk
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jira ticket: https://dsdmoj.atlassian.net/jira/software/c/projects/CBA/boards/1724?selectedIssue=CBA-71
Changes in this PR
Removes OASys import pages from risk to self and RoSH tasks, as well as stripping out now redundant OASys related code.
Screenshots of UI changes
Before
After
Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to
mainwe must firstconfirm:
Pre merge checklist
auditEvent? (seeserver/routes/apply.tsfor examples)Post merge
Once we've merged it will be auto-deployed to the dev environment.