Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API model updates #2273

Merged
merged 2 commits into from
Jan 13, 2025
Merged

API model updates #2273

merged 2 commits into from
Jan 13, 2025

Conversation

communityaccommodationtypegen[bot]
Copy link
Contributor

Updating hmpps-approved-premises-api models from OpenAPI specification. This PR was created automatically from the generate-types.yml Workflow

@communityaccommodationtypegen communityaccommodationtypegen bot force-pushed the update-api-types branch 4 times, most recently from ea01194 to c6f70ac Compare January 10, 2025 14:37
Copy link
Contributor

@davidatkinsuk davidatkinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

@@ -14,7 +14,7 @@ import {
premisesTableRows,
summaryListForPremises,
} from '.'
import { statusTextMap } from '../placements/index'
import { statusTextMap } from '../placements'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good although i don't understand this change :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/index is auto-discovered, so isn't needed -- one of those changes the IDE picked up on save! 🙂

@froddd froddd enabled auto-merge January 13, 2025 10:17
@froddd froddd merged commit b3e8f00 into main Jan 13, 2025
7 checks passed
@froddd froddd deleted the update-api-types branch January 13, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants