Cas3 bed search cleanup #2785
Cas3 bed search cleanup #2785
Conversation
daveawc
force-pushed
the
chore/bedsearch-refactor
branch
from
accba19 to
ff4c62e
Compare
...justice/digital/hmpps/approvedpremisesapi/unit/transformer/BedSearchResultTransformerTest.kt
Show resolved
Hide resolved
|
We need to be careful when migrate this PR because it will break the UI |
| @@ -1035,15 +1035,3 @@ components: | |||
| - updatedReferenceNumber | |||
| - updatedReason | |||
| - updatedNotes | |||
| ApprovedPremisesBedSearchResult: | |||
There was a problem hiding this comment.
this can't be removed currently as it will break the ui compilation and it's non trivial to unpick it
There was a problem hiding this comment.
ah ok, I did check the UI repo and it only looked like it was being used a a factory, which fred has removed in the PR in the description
There was a problem hiding this comment.
we're now safe to remove this 👍
@muhammad-elabdulla there is a UI pr for that in the PR description, https://github.com/ministryofjustice/hmpps-temporary-accommodation-ui/pull/1191/files |
|
@daveawc I saw it but if you deploy one of them the UI will break and maybe the ui e2e test not passing. It good to check with @aliuk2012 on Monday |
daveawc
force-pushed
the
chore/bedsearch-refactor
branch
from
ff4c62e to
3cf0c2a
Compare
daveawc
force-pushed
the
chore/bedsearch-refactor
branch
3 times, most recently
from
2e1a270 to
5668b6f
Compare
…it, which will help ongoing work in the area.
daveawc
force-pushed
the
chore/bedsearch-refactor
branch
from
5668b6f to
7e48609
Compare
cleaning up the bed search stuff now that cas1 and cas3 have been split, which will help ongoing work in the area.