Add diff when updating room to log output. #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
approved these changes
Jan 10, 2025
| @@ -161,11 +169,39 @@ class Cas1SeedRoomsFromSiteSurveyXlsxJob( | |||
| log.info("Created new room with code ${room.roomCode} and name ${room.roomName} in premise ${premises.name}.") | |||
| } | |||
|
|
|||
| private data class ApprovedPremisesRoomForComparison( | |||
danhumphreys-moj
force-pushed
the
chore/add-javers-comparison-to-excel-seed-rooms-job
branch
from
c5f25e1 to
663df5b
Compare
danhumphreys-moj
deleted the
chore/add-javers-comparison-to-excel-seed-rooms-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the seed room characteristics from Excel site survey data, output the difference in room characteristics between the existing room entity and the updated room entity usinng the JaVers library. This is already done when a premise is updated via the equivalent job.