APS-1787 add seed job to create applications with pending request for placements #2781
Conversation
davidatkinsuk
force-pushed
the
feature/aps-1787-add-seed-job-to-create-test-applications
branch
17 times, most recently
from
1146506 to
52d635c
Compare
|
|
||
| log.info("Creating $count applications for CRN $crn in state $state using creator username $deliusUsername") | ||
|
|
||
| runBlocking(Dispatchers.IO.limitedParallelism(10)) { |
There was a problem hiding this comment.
Other option to consider is to use CoroutineScope if we dont need to block the thread.
There was a problem hiding this comment.
i was playing around with this and i think CoroutineScope only works if being called from a suspend function, which eventually will need a runBlocking somewhere further up the call chain. But this is all quite new to me so there may be a way to do it without that. I did verify that parallelism is occurring with this configuration. My initial attempt didn't specify a dispatcher and that led to the default dispatched being used which just ran one co-routine at a time.
There was a problem hiding this comment.
I do agree though, we could consider running this without blocking. In this case I think blocking is fine as we're mostly always exhausting the parallelism on the dispatcher so not much else could happen regardless (e.g. process another CSV row)
Move logic into service in preparation for reuse
This will be used to support load testing
This commit updates the CAS1 Create Test Applications Seed Job to allow applications to be seeded as assessed. This job also uses co-routines when creating applications. limitedParallelism is set to 10 to ensure we don’t exceed the size of the JDBC connection pool. Otherwise we start seeing timeouts waiting on connections in the pool. Adding additional parallelism didn’t produce any notable gains, although that my not be the case in other better-sized environments.
davidatkinsuk
force-pushed
the
feature/aps-1787-add-seed-job-to-create-test-applications
branch
from
52d635c to
d2205ac
Compare
davidatkinsuk
deleted the
feature/aps-1787-add-seed-job-to-create-test-applications
branch
Add a seed job to create test applications that either pending submission, or pending matching
This job uses co-routines when creating applications. limitedParallelism is set to 10 to ensure we don’t exceed the size of the JDBC connection pool. Otherwise we start seeing timeouts waiting on connections in the pool. Adding additional parallelism didn’t produce any notable gains, although that my not be the case in other better-sized environments.