Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created cas2 bail project in a new space of Cas2v2 #2778

Merged
merged 12 commits into from
Jan 14, 2025

Conversation

tobybatchmoj
Copy link

This creates a new name space (Cas2v2) from the Cas2 API to handle bail applications. This will merge into a branch off main called cas2v2/dev, when the project is complete we will merge cas2v2/dev into main.

This was we avoid one massive pr at the end of the project.

@tobybatchmoj tobybatchmoj force-pushed the cas2v2/cba-83_create-a-new-cas2v2-namespace branch from e744611 to 80415a5 Compare January 9, 2025 14:53
@tobybatchmoj tobybatchmoj marked this pull request as ready for review January 13, 2025 10:52
Copy link
Contributor

@davidatkinsuk davidatkinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

There are a few comments that I think need addressing before merge. Please give me a shout if anything isn't clear.

Our release process aligns with the other CAS teams and as such [lives in Confluence](https://dsdmoj.atlassian.net/wiki/spaces/AP/pages/4247847062/Release+process). The steps are also available in the [PULL_REQUEST_TEMPLATE](/.github/PULL_REQUEST_TEMPLATE.md#release-checklist).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we squash the commits please

src/main/resources/static/_shared.yml Outdated Show resolved Hide resolved
src/main/resources/static/cas2v2-schemas.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@davidatkinsuk davidatkinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as remaining changes are not blockers

@garethCAS2 garethCAS2 merged commit 32e6c45 into cas2v2/dev Jan 14, 2025
8 checks passed
@garethCAS2 garethCAS2 deleted the cas2v2/cba-83_create-a-new-cas2v2-namespace branch January 14, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants