-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: created cas2 bail project in a new space of Cas2v2 #2778
feat: created cas2 bail project in a new space of Cas2v2 #2778
Conversation
e744611
to
80415a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There are a few comments that I think need addressing before merge. Please give me a shout if anything isn't clear.
Our release process aligns with the other CAS teams and as such [lives in Confluence](https://dsdmoj.atlassian.net/wiki/spaces/AP/pages/4247847062/Release+process). The steps are also available in the [PULL_REQUEST_TEMPLATE](/.github/PULL_REQUEST_TEMPLATE.md#release-checklist). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we squash the commits please
...v/justice/digital/hmpps/approvedpremisesapi/controller/cas2v2/Cas2v2ApplicationController.kt
Outdated
Show resolved
Hide resolved
...v/justice/digital/hmpps/approvedpremisesapi/controller/cas2v2/Cas2v2AssessmentsController.kt
Outdated
Show resolved
Hide resolved
...v/justice/digital/hmpps/approvedpremisesapi/controller/cas2v2/Cas2v2AssessmentsController.kt
Outdated
Show resolved
Hide resolved
...v/justice/digital/hmpps/approvedpremisesapi/controller/cas2v2/Cas2v2AssessmentsController.kt
Outdated
Show resolved
Hide resolved
...es/db/migration/all/20250107134233__application_controller_and_linked_services_in_cas2v2.sql
Outdated
Show resolved
Hide resolved
...es/db/migration/all/20250107134233__application_controller_and_linked_services_in_cas2v2.sql
Show resolved
Hide resolved
...t/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/integration/IntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
...v/justice/digital/hmpps/approvedpremisesapi/controller/cas2v2/Cas2v2AssessmentsController.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as remaining changes are not blockers
This creates a new name space (Cas2v2) from the Cas2 API to handle bail applications. This will merge into a branch off main called cas2v2/dev, when the project is complete we will merge cas2v2/dev into main.
This was we avoid one massive pr at the end of the project.