APS-1752 - Add get person info in batches function #2765
Conversation
davidatkinsuk
force-pushed
the
feature/aps-1752-add-common-bulk-get-offenders-function
branch
3 times, most recently
from
a4971ff to
a1a1083
Compare
davidatkinsuk
changed the title
davidatkinsuk
changed the title
davidatkinsuk
force-pushed
the
feature/aps-1752-add-common-bulk-get-offenders-function
branch
from
a1a1083 to
2768e0f
Compare
| @@ -156,42 +156,6 @@ class Cas3ReportServiceTest { | |||
| verify(exactly = 0) { mockOffenderService.getPersonSummaryInfoResults(any<Set<String>>(), any()) } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `createCas3ApplicationReferralsReport successfully generate report and call offender service 2 times when crn search limit exceed`() { | |||
| val startDate = LocalDate.of(2024, 1, 1) | |||
There was a problem hiding this comment.
This test should remain as it make sure that if the numbers of Crns exceed the bath size is called multiple times
There was a problem hiding this comment.
i've updated the code so that batching is dealt with in the OffenderService, so i think this test is now redundant? unless i'm missing another call that's made multiple times?
There was a problem hiding this comment.
In case there are 2000 crns the new code should split them to batches of 500. which means should call the function multiple times
There was a problem hiding this comment.
This is what we're now doing in OffenderService.getPersonSummaryInfoResultsInBatches and i've added unit tests to ensure this happens (albeit with a batch size of 400). Given this, there is no more batching/partitioning happening in the Cas3ReportService, so we don't need to test this specific behaviour in Cas3ReportServiceTest, hence the removal of this test function. Given me a shout on slack if you think something needs changing here, i may be misunderstanding.
Note that the check in the new code relates to the requested batch size, not the number of crns requested
if (batchSize > MAX_OFFENDER_REQUEST_COUNT) {
throw InternalServerErrorProblem("Cannot request more than $MAX_OFFENDER_REQUEST_COUNT CRNs. A batch size of $batchSize has been requested.")
}
2768e0f to
ba3e4b4
Compare
This commit updates the `Cas3ReportService` to use the new `OffenderService.getPersonSummaryInfoResultsInBatches`, removing the local batching implementations.
davidatkinsuk
force-pushed
the
feature/aps-1752-add-common-bulk-get-offenders-function
branch
from
ba3e4b4 to
81eb267
Compare
davidatkinsuk
deleted the
feature/aps-1752-add-common-bulk-get-offenders-function
branch
Add a function to get offender info in batches and update Cas3ReportService to use this function for batching requests.
This is being added as batching functionality will be required for some new CAS1 seed jobs