APS-1752 Create Seed Job to import Bookings from Delius that don't exist in CAS1 #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
force-pushed
the
feature/aps-1752-add-seed-job-to-import-delius-only-referrals
branch
7 times, most recently
from
2c2bd76 to
ae05913
Compare
davidatkinsuk
force-pushed
the
feature/aps-1752-add-seed-job-to-import-delius-only-referrals
branch
2 times, most recently
from
187ca51 to
10d8a71
Compare
This commit extracts the logic used to extract ‘Management Info’ from delius booking imports into a common service such that it can be reused for a new seed jobs that creates `SpaceBooking` for delius referrals that don’t have an existing booking in CAS1.
This commit adds a seed job to backfill `SpaceBookings` for bookings that were created directly in delius It will create an offline application for every required booking, emulating the now removed ‘manual booking’ functionality
This commit adds a seed job to backfill active CAS1 bookings created in delius that do not exist in CAS1. An active booking is one that: * does not have a departure recorded (and optionally, no arrival recorded) * does not have a non arrival recorded We also exclude any bookings where the departure date is before 1/1/2025 or after 1/1/2035. This filters out several bookings where the dates have been set incorrectly but are clearly inactive/complete, most likely because they were created in older versions of delius that did not capture this data. Note that the [Cas1DeliusBookingImportEntity] table only includes accepted bookings (i.e. not rejected), so these are already filtered out.
davidatkinsuk
force-pushed
the
feature/aps-1752-add-seed-job-to-import-delius-only-referrals
branch
from
10d8a71 to
48e26a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a seed job to backfill active CAS1 bookings created in delius that do not exist in CAS1.
An active booking is one that:
We also exclude any bookings where the departure date is before 1/1/2025 or after 1/1/2035. This filters out several bookings where the dates have been set incorrectly but are clearly inactive/complete, most likely because they were created in older versions of delius that did not capture this data