Aps 1757 raise error if characteristics are different

[danhumphreys-moj]

Ref: APS-1757

Raise error if characteristics aren't consistent between beds when beds are in the same room.

Other issues resolved such as:

• construct questionCriteriaMapping when the seed job is executed e.g. in processDataFrame, and then 'pass it around' to functions that need it (ref)

• questionCriteriaMapping shouldn’t be a class instance variable to avoid concurrency issues (ref)

• introduce a fun buildRoomCode(qCode,roomNumber) = "$qCode - $roomNumber" to reduce duplication (ref)

• consider using something like this to aid readability: rows.addCharacteristics("Is this room located on the ground floor?", listOf("N","Y","Y")) (ref)

• copy all questions into a List in this class as an instance variable, and then refer to that here instead of questionCriteriaMapping.questionToCharacterEntityMapping.keys (ref)

• consider building bespoke data classes rather than using existing entity classes - this should help simplify seed job logic (see approach in seed premises job)

[davidatkinsuk]

A really great set of improvements. LGTM 👍

[danhumphreys-moj]

Thanks @davidatkinsuk and appreciate your help with this. I know this refactoring wasn't entirely necessary but having your equivalent seed premises job along with your comments/feedback has been a really useful exercise for me.

The refactoring work done in the penultimate commit really meant I was able to address the ticket requirements in a much more straightforward manner.

Appreciate the opportunity to have done this. @Rosie-Brigham revisiting previous work and learning from it was something we raised during my last 121 and I wanted to do. This is a good example.