Merge pull request #2786 from ministryofjustice/chore/rollback-seed-j…

…ob-on-any-errors Rollback seed transaction if any errors occur
ministryofjustice · Jan 10, 2025 · 6969bb2 · 6969bb2
2 parents 54a83ff + abfc540
commit 6969bb2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/seed/SeedService.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/seed/SeedService.kt
@@ -124,6 +124,7 @@ class SeedService(
     return rowsProcessed
   }
 
+  @SuppressWarnings("TooGenericExceptionThrown")
   private fun <T> processCsv(job: SeedJob<T>, resolveCsvPath: SeedJob<T>.() -> String): Int {
     var rowNumber = 1
     val errors = mutableListOf<String>()
@@ -147,7 +148,7 @@ class SeedService(
       throw RuntimeException("Unable to process CSV at row $rowNumber", exception)
     }
     if (errors.isNotEmpty()) {
-      seedLogger.error("The following row-level errors were raised: ${errors.joinToString("\n")}")
+      throw RuntimeException("The following row-level errors were raised: ${errors.joinToString("\n")}")
     }
 
     return rowNumber - 1