Removed Cas1SpaceSearchResult.spacesAvailable

This was always populated as an empty list, and not used on the UI

src/main/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/transformer/cas1/Cas1SpaceSearchResultsTransformer.kt

@@ -47,7 +47,6 @@ class Cas1SpaceSearchResultsTransformer {
             },
           ),
           distanceInMiles = candidatePremises.distanceInMiles.toBigDecimal(),
-          spacesAvailable = listOf(),
         )
       },
     )

src/main/resources/static/cas1-schemas.yml

@@ -318,23 +318,9 @@ components:
         distanceInMiles:
           type: number
           example: 2.1
-        spacesAvailable:
-          type: array
-          deprecated: true
-          description: "This is not populated and will be removed in the future"
-          items:
-            $ref: '#/components/schemas/Cas1SpaceAvailability'
-    Cas1SpaceAvailability:
-      type: object
-      deprecated: true
-      properties:
-        spaceCharacteristics:
-          type: array
-          items:
-            $ref: '#/components/schemas/Cas1SpaceCharacteristic'
-        durationInDays:
-          type: integer
-          example: 77
+      required:
+        - premises
+        - distanceInMiles
     Cas1SpaceCategory:
       type: string
       example: arson

src/main/resources/static/codegen/built-cas1-api-spec.yml

@@ -6365,23 +6365,9 @@ components:
         distanceInMiles:
           type: number
           example: 2.1
-        spacesAvailable:
-          type: array
-          deprecated: true
-          description: "This is not populated and will be removed in the future"
-          items:
-            $ref: '#/components/schemas/Cas1SpaceAvailability'
-    Cas1SpaceAvailability:
-      type: object
-      deprecated: true
-      properties:
-        spaceCharacteristics:
-          type: array
-          items:
-            $ref: '#/components/schemas/Cas1SpaceCharacteristic'
-        durationInDays:
-          type: integer
-          example: 77
+      required:
+        - premises
+        - distanceInMiles
     Cas1SpaceCategory:
       type: string
       example: arson

src/test/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/integration/cas1/Cas1SpaceSearchTest.kt

@@ -364,10 +364,9 @@ class Cas1SpaceSearchTest : InitialiseDatabasePerClassTestBase() {
     expectedApType: ApType = ApType.normal,
     expectedCharacteristics: List<Cas1SpaceCharacteristic>? = null,
   ) {
-    assertThat(actual.spacesAvailable).isEmpty()
     assertThat(actual.distanceInMiles).isGreaterThan(0f.toBigDecimal())
     assertThat(actual.premises).isNotNull
-    val premises = actual.premises!!
+    val premises = actual.premises
     assertThat(premises.id).isEqualTo(expected.id)
     assertThat(premises.apType).isEqualTo(expectedApType)
     assertThat(premises.name).isEqualTo(expected.name)

src/test/kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/unit/transformer/cas1/Cas1SpaceSearchResultsTransformerTest.kt

@@ -89,7 +89,6 @@ class Cas1SpaceSearchResultsTransformerTest {
     assertThat(premises1.premisesCharacteristics).isEmpty()
     assertThat(premises1.characteristics).isEmpty()
     assertThat(actual.results[0].distanceInMiles).isEqualTo(BigDecimal.valueOf(1.0))
-    assertThat(actual.results[0].spacesAvailable).isEmpty()
 
     val premises2 = actual.results[1].premises
     assertThat(premises2).isNotNull
@@ -107,6 +106,5 @@ class Cas1SpaceSearchResultsTransformerTest {
     assertThat(premises2.premisesCharacteristics).isEmpty()
     assertThat(premises2.characteristics).isEmpty()
     assertThat(actual.results[1].distanceInMiles).isEqualTo(BigDecimal.valueOf(2.0))
-    assertThat(actual.results[1].spacesAvailable).isEmpty()
   }
 }