Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔔 Notify Operations Engineering When a Manual Change Occurs #42

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

jasonBirchall
Copy link
Contributor

👀 Purpose

  • Now we manage our DNS estate in code, it's important that we don't revert back to making changes via the console.
  • If a change is made via the console and not recorded here, we should be made aware of it.
  • This only works if a hostedzone is created in the console. If it's just a record, then octodns will wipe out this change on its next run. This forces folks into good practice.

♻️ What's changed

  • A new Python file that enables us to check what's in AWS and what's in this repository.
  • A makefile to execute this Python file.
  • A GitHub Action will check this automatically every day at 0000.
  • A pytest file that checks the accuracy of the code included in this PR.
  • A GitHub Action that automatically runs the pytest command when a python file is changed in the repository.

📝 Notes

@jasonBirchall jasonBirchall requested a review from a team as a code owner June 25, 2024 16:17
Copy link

github-actions bot commented Jun 25, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML prettier 2 1 0 0.27s
❌ YAML yamllint 2 1 0.2s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝🌖🚀LGTM🚀🌘🌚

@jasonBirchall jasonBirchall merged commit d1795a9 into main Jun 26, 2024
2 of 3 checks passed
@jasonBirchall jasonBirchall deleted the state-drift branch June 26, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants