Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in support of new Judicial College service #317

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

AntonyBishop
Copy link
Contributor

@AntonyBishop AntonyBishop commented Dec 10, 2024

👀 Purpose

  • The PR makes changes to judicialcollege.judiciary.gov.uk subdomains in support of migration to a new service.

♻️ What's changed

  • Add A Record judicialcollege.judiciary.gov.uk
  • Remove CNAME judicialcollege.judiciary.gov.uk
  • Remove CNAME _dmarc.judicialcollege.judiciary.gov.uk
  • Remove CNAME kineolms._domainkey.judicialcollege.judiciary.gov.uk
  • Add TXT record default._domainkey.judicialcollege.judiciary.gov.uk
  • Add TXT record judicialcollege.judiciary.gov.uk

📝 Notes

Request

  • DO NOT MERGE BEFORE 16th DECEMBER 2024 - AWAITING GO/NO-GO DECISION

@AntonyBishop AntonyBishop self-assigned this Dec 10, 2024
@AntonyBishop AntonyBishop requested a review from a team as a code owner December 10, 2024 16:41
Copy link

github-actions bot commented Dec 10, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML prettier 1 1 0 0.29s
✅ YAML yamllint 1 0 0.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@AntonyBishop AntonyBishop marked this pull request as draft December 10, 2024 16:43
@AntonyBishop
Copy link
Contributor Author

Updating as you can't have a TXT and CNAME with same name. Awaiting requester input.

@AntonyBishop AntonyBishop marked this pull request as ready for review December 11, 2024 13:08
@AntonyBishop
Copy link
Contributor Author

Requester provided additional information so can now add TXT and A Record

Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝🌖🚀LGTM🚀🌘🌚

@AntonyBishop AntonyBishop marked this pull request as draft December 11, 2024 13:13
@AntonyBishop
Copy link
Contributor Author

Change brought forward to the 16th at the request of the Business

@AntonyBishop AntonyBishop marked this pull request as ready for review December 16, 2024 14:20
@AntonyBishop AntonyBishop merged commit 49c252a into main Dec 16, 2024
3 checks passed
@AntonyBishop AntonyBishop deleted the AntonyBishop-patch-1 branch December 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants