Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Change Output of Python Error Message #262

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

jasonBirchall
Copy link
Contributor

This pull request includes changes to the .github/workflows/check-unmanaged-zones.yaml file to improve the handling and notification of unmanaged zones. The most important changes include capturing the output of the make check-unmanaged-zones command and correcting a typo in the Slack notification.

Workflow improvements:

This should tell me whether we are capturing the output, but not displaying it correctly in the step below.
This ensures the json block that's passed to the slack alert is valid json
@jasonBirchall jasonBirchall requested a review from a team as a code owner November 5, 2024 11:26
@jasonBirchall jasonBirchall changed the title ♻️ Change Output of Slack Message ♻️ Change Output of Python Error Message Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@andyrogers1973 andyrogers1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonBirchall jasonBirchall merged commit 4031fbe into main Nov 5, 2024
4 checks passed
@jasonBirchall jasonBirchall deleted the fix-output-slack-messgae-2 branch November 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants