Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix Workflow Failures by Updating Makefile to Use Correct Script Path #260

Merged
merged 3 commits into from
Nov 5, 2024
Merged

🔧 Fix Workflow Failures by Updating Makefile to Use Correct Script Path #260

merged 3 commits into from
Nov 5, 2024

Conversation

connormaglynn
Copy link
Contributor

@connormaglynn connormaglynn commented Nov 5, 2024 •
edited
Loading

👀 Purpose

♻️ What's changed

  • Updates paths in the Makefile to use the new directory structure
  • Pinned all GitHub Actions Versions
  • Removed the Display Results step from the Print Empty Zones workflow - the script already does this and then step made ShellCheck complain

@connormaglynn connormaglynn requested a review from a team as a code owner November 5, 2024 08:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.02s
✅ YAML prettier 4 0 0 0.38s
✅ YAML yamllint 4 0 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@connormaglynn connormaglynn force-pushed the fix-workflows-by-updating-makefile branch from e1816de to 41e2b98 Compare November 5, 2024 08:28
@connormaglynn connormaglynn force-pushed the fix-workflows-by-updating-makefile branch from 41e2b98 to 49f11e3 Compare November 5, 2024 08:29
andyrogers1973
andyrogers1973 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@andyrogers1973 andyrogers1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@connormaglynn connormaglynn merged commit f7166b5 into main Nov 5, 2024
2 checks passed
@connormaglynn connormaglynn deleted the fix-workflows-by-updating-makefile branch November 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrogers1973 andyrogers1973 andyrogers1973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connormaglynn @andyrogers1973