CDPT-2390 CT: Hide Send Commissioning Email button for Offender SAR Complaints #2534
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeenaModhvadia
had a problem deploying
to
development
GitHub Actions
Error
vertism
reviewed
Jan 8, 2025
| @@ -44,7 +44,7 @@ div class="case" | |||
| td | |||
| span = @commissioning_document&.download_link | |||
|
|
|||
| - if @data_request_area.data_request_emails.blank? && policy(@case).can_record_data_request? | |||
| - if @data_request_area.data_request_emails.blank? && policy(@case).can_record_data_request? && [email protected]_sar_complaint? | |||
There was a problem hiding this comment.
Maybe we can replace policy(@case).can_record_data_request? with a policy method that relates to sending the email and that will differ depending in whether the case is a complaint or not.
There was a problem hiding this comment.
There is an action of 'send_day_1_email' that is not enabled for complaints which is what causes the error, so that is what should be used to determine if sending is allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functionality to send a commissioning email should not be available for the case type of Offender SAR Complaints data requests. The button 'send commissioning email' needs to be hidden.
Self-review checklist
CT-7654 ...Screenshots
Related JIRA tickets
https://dsdmoj.atlassian.net/browse/CDPT-2390
Deployment
Manual testing instructions
Create offender sar and link to complaint types Standard, ICO & Litigation.