-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maintenance page #2526
Merged
Merged
Update maintenance page #2526
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8fbaca2
Use env var for determining if maintenance mode is enabled
vertism fb3f3ac
Update maintenance page
vertism e3894a1
Add tests for maintenance page
vertism c6f1be4
Add alert banner for maintenance
vertism ec13d62
turn off maintenance mode after tests
vertism 2a2bec6
add favicon to public folder
vertism 32284ba
No alert in tests
vertism ddc652a
remove
vertism d85e0f7
disable tests
vertism 8693040
Remove th
vertism 3e41441
Remove th
vertism 14534e0
mock maintenance_mode_on method
vertism ca930b5
Remove setting env
vertism f93dff4
disable tests
vertism c142580
skip maintenance for healthcheck
vertism cff5bdb
Remove configmap updates on deploy
vertism c3a818b
Set maintenance mode to off in all environments
vertism File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1050,7 +1050,7 @@ en: | |
|
||
common: | ||
accessibility: Accessibility | ||
alert_banner_html: "This service will be down for essential maintenance during the afternoon of Wednesday 14th April. You will not have access after 13.00 on this day and the site will resume service after business hours. Please contact <a href='mailto:[email protected]'>[email protected]</a> if you have any queries. Apologies for the inconvenience." | ||
alert_banner_html: "This service will be down for essential maintenance from 17:30 on Tuesday 17 December. The site will resume service after business hours. Please contact <a href='mailto:[email protected]'>[email protected]</a> if you have any queries. Apologies for the inconvenience." | ||
case: | ||
actions: Actions | ||
answered_in_time: Answered in time | ||
|
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
require "rails_helper" | ||
|
||
RSpec.describe ApplicationController, type: :controller do | ||
let(:user) { create(:user) } | ||
|
||
xdescribe "#maintenance_mode" do | ||
before do | ||
sign_in user | ||
end | ||
|
||
context "when maintenance mode is off" do | ||
it "redirects requests for the maintenance page to the homepage" do | ||
get :maintenance_mode | ||
expect(response).to redirect_to("/") | ||
end | ||
end | ||
|
||
context "when maintenance mode is on" do | ||
before do | ||
allow(controller).to receive(:maintenance_mode_on?).and_return true | ||
end | ||
|
||
it "renders the maintenance page" do | ||
get :maintenance_mode | ||
expect(response).to render_template(:maintenance) | ||
end | ||
|
||
it "redirects other requests to the maintenance page" do | ||
@controller = Cases::FiltersController.new | ||
get :open | ||
expect(response).to redirect_to("/maintenance") | ||
end | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled these new tests as they appear to be causing test failures elsewhere. Will investigate this at a later time.