Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix probation template bug #2525

Conversation

lucas-shaw
Copy link
Contributor

Description

When trying to download the probation template, an error occurred due to data_required not being a method of DataRequestAreaDecorator

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...
  • (8) Data migration script is created if any of letter templates is changed

Screenshots

Related JIRA tickets

Deployment

Manual testing instructions

@lucas-shaw lucas-shaw changed the base branch from main to cdpt-1850-commissioning-and-chase-redesign December 13, 2024 14:01
@lucas-shaw lucas-shaw marked this pull request as ready for review December 13, 2024 14:07
@lucas-shaw lucas-shaw requested review from a team as code owners December 13, 2024 14:07
Copy link
Contributor

@vertism vertism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-shaw lucas-shaw merged commit 43e80db into cdpt-1850-commissioning-and-chase-redesign Dec 13, 2024
14 checks passed
@lucas-shaw lucas-shaw deleted the fix-probation-template-bug branch December 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants