Update crest and number to letter templates #2519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-shaw
changed the base branch from
main
to
cdpt-1850-commissioning-and-chase-redesign
lucas-shaw
changed the title
…288-update-crest-and-number-to-letter-templates
lucas-shaw
commented
Nov 28, 2024
| @@ -34,6 +35,8 @@ def render(values, letter, field) | |||
| end | |||
|
|
|||
| def telephone_number | |||
| return COMPLAINT_ACKNOWLEDGEMENT_LETTER_TEL_NUM if abbreviation == "complaint-acknowledgement" | |||
There was a problem hiding this comment.
Not sure if its the best way to implement, however I didnt think it was a good idea to create a new template_type enum
lucas-shaw
deleted the
cdpt-2288-update-crest-and-number-to-letter-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Self-review checklist
CT-7654 ...Screenshots
Related JIRA tickets
https://dsdmoj.atlassian.net/jira/software/c/projects/CDPT/boards/1152?selectedIssue=CDPT-2288
Deployment
Manual testing instructions