Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commissioning and chase redesign #2471

Merged
merged 33 commits into from
Dec 17, 2024

Conversation

lucas-shaw
Copy link
Contributor

@lucas-shaw lucas-shaw commented Sep 10, 2024

Description

Offender SAR and Offender complaint cases now use data request areas to manage data requests. This groups associated data requests with the same address for better management. Pre existing data requests have been migrated to this new format, each with their own area.

Commissioning documents have been updated to use a new standard template that dynamically lists data request information. Commissioning documents that have already been emailed, will be migrated over into their respective area and will remain unaffected.

This precedes the automated chase work which will be implemented later.

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...
  • (8) Data migration script is created if any of letter templates is changed

Screenshots

Related JIRA tickets

https://dsdmoj.atlassian.net/jira/software/c/projects/CDPT/boards/1152?selectedIssue=CDPT-1850

Deployment

Manual testing instructions

@lucas-shaw lucas-shaw marked this pull request as ready for review December 17, 2024 14:48
@lucas-shaw lucas-shaw requested review from a team as code owners December 17, 2024 14:48
Copy link
Contributor

@vertism vertism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-shaw lucas-shaw merged commit 0754f6c into main Dec 17, 2024
14 checks passed
@lucas-shaw lucas-shaw deleted the cdpt-1850-commissioning-and-chase-redesign branch December 17, 2024 15:24
vertism added a commit that referenced this pull request Dec 17, 2024
vertism added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants