Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-2798: Announce we’re calling from CLA #130

Merged
merged 21 commits into from
Jan 3, 2024
Merged

LGA-2798: Announce we’re calling from CLA #130

merged 21 commits into from
Jan 3, 2024

Conversation

BenMillar-MOJ
Copy link
Contributor

@BenMillar-MOJ BenMillar-MOJ commented Dec 19, 2023 •
edited
Loading

What does this pull request do?

  • Adds end to end tests for the four journeys a user can take through the contact us page which affects the announcement warning.

Any other changes that would benefit highlighting?

  • Additional improvements to generalise testing steps.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

psweeting1 and others added 16 commits December 15, 2023 08:31
@psweeting1
WIP: LGA-2798 basic outline and structure for yes announce call path
d6b2f46
@psweeting1
WIP: Updating docker-compose file to use correct development branches
6de7b37
@psweeting1
WIP: updated cla_backend git commit number to reflect correct branch
961a095
@psweeting1
LGA-2798 new steps for selecting values again announce call options
76a18aa
@psweeting1
LGA-2798 New steps to capture users reference number from contact us …
8cbe70c 
…jounery. New step to search for a saved case.
@BenMillar-MOJ
Added feature definitions for additional contact us journeys
e269ed6
@BenMillar-MOJ
Updated search and save function to be named 'I search for and select…
59e66b6 
… a case using my saved reference number'
@BenMillar-MOJ
Added tests to assert if the call announce warning is present
0b8b4ad
@psweeting1
WIP: removing imports for A11Y to prevent pre-commit lint issues
633de12
@psweeting1
LGA-2798 updated steps with new input values checks. Fixed step call …
322ae48 
…issue. Changed H1 checks on confirm page.
@BenMillar-MOJ
Added additional steps to the 'Call someone else instead of me' test
840a38a
@BenMillar-MOJ
Merge branch 'feature/LGA-2798-announce-calling-cla' of https://githu…
d7cb0de 
…b.com/ministryofjustice/cla-end-to-end-tests into feature/LGA-2798-announce-calling-cla
@BenMillar-MOJ
Renamed tag on new features
47f926d
@BenMillar-MOJ
Reverted docker-compose commit tags
f217418
@BenMillar-MOJ
Reverted changes to environment.py
b349604
@BenMillar-MOJ
Reverted unintentional indentation
8e0c6a9
TawneeOwl
TawneeOwl previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

digitalali-moj
digitalali-moj previously approved these changes Dec 21, 2023
View reviewed changes
@psweeting1 psweeting1 dismissed stale reviews from digitalali-moj and TawneeOwl via 9d93a69 December 21, 2023 13:16
TawneeOwl
TawneeOwl previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

digitalali-moj
digitalali-moj previously approved these changes Dec 21, 2023
View reviewed changes
Copy link

@digitalali-moj digitalali-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing this!

TawneeOwl
TawneeOwl approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

said-moj
said-moj approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@said-moj said-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psweeting1 psweeting1 merged commit a94fa97 into main Jan 3, 2024
6 checks passed
@psweeting1 psweeting1 deleted the feature/LGA-2798-announce-calling-cla branch January 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TawneeOwl TawneeOwl TawneeOwl approved these changes

@said-moj said-moj said-moj approved these changes

@digitalali-moj digitalali-moj digitalali-moj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenMillar-MOJ @digitalali-moj @said-moj @TawneeOwl @psweeting1