-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: add a star icon next to the "starred" nav menu item #3031
base: main
Are you sure you want to change the base?
Conversation
What's the point of adding an icon? The |
Having an icon on every navigation menu option is indeed better, yes :) |
Bikeshedding: add icons to the left or to the right side? If we'll add icons to all menu items, left is better IMHO for (i) consistency with the existing icons and (ii) so that "Feeds" has the icon on the left and the (+) button on the right. Adding more icons is reasonable, will revisit this PR once I have cycles to do so. |
I don't know shit about design, so I usually look at the GNOME Human Interface Guidelines. It recommends the following:
A notable execption to this rules are the header bars, which can be more or less seen as equivalent to Miniflux' horizontal navigation menu, so I guess it's ok. In Adwaita, the building blocks for modern GNOME applications, the icons are on the left of their label: |
add magnifying glass
add settings icon
add feeds
An idea of what it could look like with a couple of emojis: Also, to be frank, I am not a big fan of the emojis in this context, because their color is distracting. That's why the original PR included a non-emoji star. With that said: We could incorporate more icons from https://tabler.io/icons, like #1335. They blend in well with the existing ones and they are not distracting, as they are all monochromatic. Some possibilities are:
|
...of course, whether to proceed from here is up to Frédéric. |
I'm okay with that. New icons from tabler.io can be added to the sprite.svg file. Of course, that must be consistent with the rest of the application. Some testing with languages other than English might be required to avoid text overflow. For example, French and German are more verbose compared to English. |
STATUS: On Hold. Revisit:
This is somewhat of a follow-up of #1371.
It looks like this:
And with hover:
Initially I added the emoji star (⭐️) but it stood out too much. I find that the unicode star blends in well with the rest of the menu.
This change is purely aesthetic.
Do you follow the guidelines?