Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add rule for deprecating singletons" #181619

Merged
merged 1 commit into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions .github/policies/labelAdded.manifestSingletonDeprecated.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ configuration:
resourceManagementConfiguration:
eventResponderTasks:
- description: >-
When the label "Manifest-Version-Deprecated" is added to a pull request
When the label "Manifest-Version-Error" is added to a pull request
* Add the PR specific reply notifying the issue author
* Assign to the Author
* Label with Needs-Author-Feedback
Expand Down
30 changes: 0 additions & 30 deletions .github/policies/labelManagement.issueOpened.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,35 +206,5 @@ configuration:
then:
- addLabel:
label: Author-Not-Authorized
- description: >-
When a PR is opened/updated, if
* The files are in /manifests
* The files match *.yaml
* The files do not match *.installer.yaml
* The files do no match *.locale.yaml
Then
* Add label Manifest-Singleton-Deprecated
if:
- payloadType: Pull_Request
- isOpen
- or:
- isAction:
action: Opened
- isAction:
action: Synchronize
- not:
filesMatchPattern: # has at least one file
pattern: ^$
- filesMatchPattern:
pattern: ^manifests/.*\.yaml # matches manifests/*.yaml
- not:
filesMatchPattern:
pattern: ^manifests/.*\.installer\.yaml # matches manifests/*.installer.yaml
- not:
filesMatchPattern:
pattern: ^manifests/.*\.locale\..*\.yaml # matches manifests/*.locale.*.yaml
then:
- addLabel:
label: Manifest-Singleton-Deprecated
onFailure:
onSuccess: