testing: fix markdown messages not displaying #224612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time markdown messages were rendered, the output element was not in the DOM, so its height was always 0. It was also missing a couple of style adjustments. Additionally it tweaks the diff height before we fall back to nested scrollbars -- a limit of 1000px was very low. I had this commit on a branch from earlier but it never made it to PR :x Refs #224575
kalebers
approved these changes
Aug 5, 2024
karthiknadig
approved these changes
Aug 5, 2024
zongou
pushed a commit
to zongou/vscode
that referenced
this pull request
Aug 13, 2024
At the time markdown messages were rendered, the output element was not in the DOM, so its height was always 0. It was also missing a couple of style adjustments. Additionally it tweaks the diff height before we fall back to nested scrollbars -- a limit of 1000px was very low. I had this commit on a branch from earlier but it never made it to PR :x Refs microsoft#224575
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Sep 2, 2024
At the time markdown messages were rendered, the output element was not in the DOM, so its height was always 0. It was also missing a couple of style adjustments. Additionally it tweaks the diff height before we fall back to nested scrollbars -- a limit of 1000px was very low. I had this commit on a branch from earlier but it never made it to PR :x Refs microsoft#224575
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.
I had this commit on a branch from earlier but it never made it to PR :x
Closes #224575