-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lwlog] Added new library #43047
base: master
Are you sure you want to change the base?
[lwlog] Added new library #43047
Conversation
@microsoft-github-policy-service agree |
I have two more questions:
|
Co-authored-by: Cheney Wang <[email protected]>
Co-authored-by: Cheney Wang <[email protected]>
Co-authored-by: Cheney Wang <[email protected]>
Co-authored-by: Cheney Wang <[email protected]>
Co-authored-by: Cheney Wang <[email protected]>
@Cheney-W Regarding your first question, actually no, maybe I should make some changes to the cmake, but sandbox shouldn't neccessarily come with the library. |
…c-lwlog merge master
Co-authored-by: Cheney Wang <[email protected]>
AFAICT this must not be in this port, given its binary artifacts.
|
It is fine to organize everything in |
I fully agree. Just pushed the changes |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.