Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alsa] Fix multiple find_package(ALSA REQUIRED) #43008

Merged
merged 4 commits into from
Jan 2, 2025
Merged

[alsa] Fix multiple find_package(ALSA REQUIRED) #43008

merged 4 commits into from
Jan 2, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 30, 2024

Resolves #42929.

@dg0yt dg0yt mentioned this pull request Dec 30, 2024
Closed
7 tasks
@dg0yt dg0yt mentioned this pull request Dec 30, 2024
Closed
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 30, 2024
@BillyONeal
Copy link
Member

Just to make sure I understand, there are 2 changes here:

  1. Removing what is effectively a debug check that probably shouldn't run during a user's configure.
  2. "Promoting" ALSA_LIBRARY to a cache variable.

and those are really independent changes?

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 31, 2024

Yes, those are two independent changes.

@BillyONeal BillyONeal merged commit fa643c3 into microsoft:master Jan 2, 2025
17 checks passed
BillyONeal pushed a commit that referenced this pull request Jan 2, 2025
@dg0yt
[alsa] Fix multiple find_package(ALSA REQUIRED) (#43008)
fa643c3
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the alsa branch January 3, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[imgui,sdl2,alsa] Build error on x64-linux
3 participants
@dg0yt @BillyONeal @FrankXie05