Compiler detection: Cache compiler hash #42994
Open
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mengna-Li
added
the
category:tool-update
Mengna-Li
requested changes
Dec 30, 2024
Mengna-Li
approved these changes
Jan 2, 2025
JavierMatosD
added
the
requires:vcpkg-team-review
BillyONeal
reviewed
Jan 3, 2025
| set(${out_var} "${HASH}" PARENT_SCOPE) | ||
| endfunction() | ||
|
|
||
| if(VCPKG_COMPILER_CACHE_FILE) |
There was a problem hiding this comment.
Should this be
Suggested change
| if(VCPKG_COMPILER_CACHE_FILE) | |
| if(DEFINED VCPKG_COMPILER_CACHE_FILE) |
?
There was a problem hiding this comment.
No. The variable is passed to this port by -DVCPKG_COMPILER_CACHE_FILE=${VCPKG_COMPILER_CACHE_FILE}, but if an "old" vcpkg-tool is used the variable is not defined in the portfile and an empty variable gets defined.
Co-authored-by: Billy O'Neal <[email protected]>
dg0yt
reviewed
Jan 4, 2025
| @@ -18,6 +18,8 @@ set(VCPKG_BUILD_TYPE release) | |||
| vcpkg_configure_cmake( | |||
| SOURCE_PATH "${CMAKE_CURRENT_LIST_DIR}" | |||
| PREFER_NINJA | |||
| OPTIONS | |||
| -DVCPKG_COMPILER_CACHE_FILE=${VCPKG_COMPILER_CACHE_FILE} | |||
There was a problem hiding this comment.
Suggested change
| -DVCPKG_COMPILER_CACHE_FILE=${VCPKG_COMPILER_CACHE_FILE} | |
| "-DVCPKG_COMPILER_CACHE_FILE=${VCPKG_COMPILER_CACHE_FILE}" | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements microsoft/vcpkg-tool#362 (comment)
Speeds up the compiler hashing if the compiler file is large like on macOS (250 MB for cc and c++ each)