Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfml] Update SFML to 3.0.0 #42913

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[sfml] Update SFML to 3.0.0 #42913

wants to merge 1 commit into from
+14 −152

Conversation

eXpl0it3r
Copy link
Contributor

@eXpl0it3r eXpl0it3r commented Dec 24, 2024 •
edited
Loading

Fixes #43000

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This updates SFML to the recently released 3.0.0 version.

@eXpl0it3r
Copy link
Contributor Author

Looks like we need to limit SFML usage to SFML 2.x, until the packages are updated.

  • SFGUI
  • Imgui-SFML
  • Thor

I tried to understand versioning, but don't fully understand it. Can someone give me a hint, how one would for example limit Thor to SFML 2.* (or even better SFML 2.5 and later SFML 2.* versions)?

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 25, 2024
@ChrisThrasher ChrisThrasher mentioned this pull request Dec 30, 2024
Open
This was referenced Dec 30, 2024
Closed
Merged
@alvarogalloc
Copy link

Can SFML ship the in vcpkg like SDL? In SDL there are ports for all three major versions. If this happens to SFML, maybe as the new release is adapted to dependent packages (e.g. thor, imgui-SFML, etc.), they can be released as feature variants of the existing ones (e.g. imgui-sfml[sfml3])

@eXpl0it3r
Copy link
Contributor Author

The guide says that one shouldn't create new ports for different versions (i.e. sfml2 & sfml3). So I guess that would be a question for @BillyONeal or similar.

@BillyONeal
Copy link
Member

The guide says that one shouldn't create new ports for different versions (i.e. sfml2 & sfml3). So I guess that would be a question for @BillyONeal or similar.

Can they be installed side-by-side without stomping on each other?

@ChrisThrasher
Copy link

https://github.com/SFML/imgui-sfml/releases/tag/v3.0

ImGui-SFML 3 has been released which targets SFML 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sfml] update to 3.0.0
5 participants
@eXpl0it3r @alvarogalloc @BillyONeal @ChrisThrasher @JonLiu1993