Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple regression before it's shipped :) #4678

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313
Copy link
Member Author

/backport to rel/3.7

Copy link
Contributor

Started backporting to rel/3.7: https://github.com/microsoft/testfx/actions/runs/12807469741

Copy link
Contributor

@Youssef1313 backporting to rel/3.7 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix tuple regression before it's shipped :)
Using index info to reconstruct a base tree...
M	src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Falling back to patching base and 3-way merge...
Auto-merging src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix tuple regression before it's shipped :)
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!**

@Youssef1313
Copy link
Member Author

/backport to rel/3.7

Copy link
Contributor

Started backporting to rel/3.7: https://github.com/microsoft/testfx/actions/runs/12807595061

@Youssef1313
Copy link
Member Author

Youssef1313 commented Jan 16, 2025

Let's see if the backport is smart enough to force push the existing branch

Copy link
Contributor

@Youssef1313 backporting to rel/3.7 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix tuple regression before it's shipped :)
Using index info to reconstruct a base tree...
M	src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Falling back to patching base and 3-way merge...
Auto-merging src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
CONFLICT (content): Merge conflict in src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix tuple regression before it's shipped :)
Error: The process '/usr/bin/git' failed with exit code 128

NOTE: A PR will be created, but needs to be revised manually!**

@Youssef1313 Youssef1313 merged commit 4a47388 into microsoft:main Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants