Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused source gen related code #4662

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Drop unused source gen related code #4662

merged 3 commits into from
Jan 15, 2025

Conversation

Evangelink
Copy link
Member

Fixes #4338

@Evangelink Evangelink enabled auto-merge (squash) January 15, 2025 19:44
Youssef1313
Youssef1313 previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new source gen doesn't seem to be moving forward for now. We can bring that back if it ever happened.

@Evangelink Evangelink merged commit 96cd76b into microsoft:main Jan 15, 2025
8 checks passed
@Evangelink Evangelink deleted the drop-sg branch January 15, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceGeneratedReflectionOperations.GetDeclaredMethod should throw if multiple methods are found.
2 participants
@Evangelink @Youssef1313