Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup to Assert.AreEqual #4472

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Small cleanup to Assert.AreEqual #4472

merged 1 commit into from
Dec 30, 2024
+4 −28

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 requested a review from Copilot December 30, 2024 05:43
Copilot
Copilot AI reviewed Dec 30, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@Youssef1313
Copy link
Member Author

Youssef1313 commented Dec 30, 2024 •
edited
Loading 

failed AssemblyInitialize_WhenTimeoutExpires_AssemblyInitializeIsCanceled_AttributeTakesPrecedence ("net462") (3s 673ms)
  StringAssert.Contains failed. String 'MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  failed Test1 (0ms)
    Assembly cleanup method 'TestClass.AssemblyCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestAssemblyInfo.ExecuteAssemblyCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  [+0/x1/?0] CodeWithOneSecTimeout.exe (net462|x64)(3s)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 062ms' does not contain string 'Assembly initialize method 'TestClass.AssemblyInit' timed out after 1000ms'. Expression 'AssertOutputContains' failed for member 'RunAndAssertWithRunSettingsAsync' at line 411 of file '/_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs'. Output of the test host is:
  Command: D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe --settings D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\da73ecfab3b54ccfbb523d407df1c632.runsettings
  ====================
  ExitCode: 2
  ====================
  StandardOutput:
  MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  failed Test1 (0ms)
    Assembly cleanup method 'TestClass.AssemblyCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestAssemblyInfo.ExecuteAssemblyCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  [+0/x1/?0] CodeWithOneSecTimeout.exe (net462|x64)(3s)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 062ms
  ====================
  StandardError:
  
  .
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.RunAndAssertWithRunSettingsAsync(String tfm, Int32 timeoutValue, Boolean assertAttributePrecedence, String entryKind) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:411
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.AssemblyInitialize_WhenTimeoutExpires_AssemblyInitializeIsCanceled_AttributeTakesPrecedence(String tfm) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:97


failed ClassInitialize_WhenTimeoutExpires_ClassInitializeIsCanceled_AttributeTakesPrecedence ("net462") (3s 744ms)
  StringAssert.Contains failed. String 'MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  [+0/x0/?0] CodeWithOneSecTimeout.exe (net462|x64) - Test1 (3s)
  failed Test1 (0ms)
    Class cleanup method 'TestClass.ClassCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestClassInfo.ExecuteClassCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 203ms' does not contain string 'Class initialize method 'TestClass.ClassInit' timed out after 1000ms'. Expression 'AssertOutputContains' failed for member 'RunAndAssertWithRunSettingsAsync' at line 411 of file '/_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs'. Output of the test host is:
  Command: D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe --settings D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\f387f85e604a42e98055a2ae8e8192db.runsettings
  ====================
  ExitCode: 2
  ====================
  StandardOutput:
  MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  [+0/x0/?0] CodeWithOneSecTimeout.exe (net462|x64) - Test1 (3s)
  failed Test1 (0ms)
    Class cleanup method 'TestClass.ClassCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestClassInfo.ExecuteClassCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 203ms
  ====================
  StandardError:
  
  .
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.RunAndAssertWithRunSettingsAsync(String tfm, Int32 timeoutValue, Boolean assertAttributePrecedence, String entryKind) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:411
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.ClassInitialize_WhenTimeoutExpires_ClassInitializeIsCanceled_AttributeTakesPrecedence(String tfm) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:102

failed BaseClassInitialize_WhenTimeoutExpires_ClassInitializeIsCanceled_AttributeTakesPrecedence ("net462") (3s 800ms)
  StringAssert.Contains failed. String 'MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  [+0/x0/?0] CodeWithOneSecTimeout.exe (net462|x64) - Test1 (3s)
  failed Test1 (0ms)
    Class cleanup method 'TestClass.ClassCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestClassInfo.ExecuteClassCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 125ms' does not contain string 'Class initialize method 'TestClassBase.ClassInitBase' timed out after 1000ms'. Expression 'AssertOutputContains' failed for member 'RunAndAssertWithRunSettingsAsync' at line 411 of file '/_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs'. Output of the test host is:
  Command: D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe --settings D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\55f5e14cddec4e5ea2e6a5b593fcf847.runsettings
  ====================
  ExitCode: 2
  ====================
  StandardOutput:
  MSTest v3.8.0-ci (UTC 12/30/2024) [x64 - .NET Framework 4.8.9287.0]
  [+0/x0/?0] CodeWithOneSecTimeout.exe (net462|x64) - Test1 (3s)
  failed Test1 (0ms)
    Class cleanup method 'TestClass.ClassCleanupMethod' timed out after 1000ms
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestClassInfo.ExecuteClassCleanup(TestContext testContext)
      at Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typeCache, UnitTestResult[] results)
  Test run summary: Failed! - D:\a\_work\1\s\artifacts\tmp\Release\testsuite\dReeB\CodeWithOneSecTimeout\bin\Release\net462\CodeWithOneSecTimeout.exe (net462|x64)
    total: 1
    failed: 1
    succeeded: 0
    skipped: 0
    duration: 3s 125ms
  ====================
  StandardError:
  
  .
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.RunAndAssertWithRunSettingsAsync(String tfm, Int32 timeoutValue, Boolean assertAttributePrecedence, String entryKind) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:411
    at MSTest.Acceptance.IntegrationTests.TimeoutTests.BaseClassInitialize_WhenTimeoutExpires_ClassInitializeIsCanceled_AttributeTakesPrecedence(String tfm) in /_/test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TimeoutTests.cs:107

@Evangelink 😢

I'm going to restart for now. It's generally much less flaky than before

@Evangelink Evangelink merged commit ec5041a into microsoft:main Dec 30, 2024
11 checks passed
@Youssef1313 Youssef1313 deleted the assert-areequal-cleanup branch December 30, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @Evangelink