perf in LogMessage #4453
Open
perf in LogMessage #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Dec 26, 2024
|
I have synced the Polyfill package. |
|
@Evangelink We need to add the updated version to https://github.com/dotnet/source-build-reference-packages/tree/main/src/textOnlyPackages/src/polyfill/ I'll take care of that. |
|
I opened dotnet/source-build-reference-packages#1105 |
Youssef1313
reviewed
Dec 29, 2024
| // Making sure all event handlers are called in sync on same thread. | ||
| foreach (Delegate invoker in OnLogMessage.GetInvocationList()) | ||
| foreach (LogMessageHandler invoker in DelegatePolyfill.EnumerateInvocationList(OnLogMessage)) |
There was a problem hiding this comment.
Note: we don't call Logger.LogMessage at all. I don't know how much consumers will be calling this, but it doesn't seem to be a hot path.
@Evangelink I'm not sure if there are "valid" use cases for this Logger class or not. If not, we should consider breaking in v4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume logging is in the hot path. so a few more lines for better oerf is justified
move over to using EnumerateInvocationList